Plasmic sync not doing relative import paths

Issues
61

So I would expect plasmic to pick up that change and update the PlasmicOsitoEmailLayout.tsx file which currently looks like this:

// app/components/plasmic/osito/PlasmicOsitoEmailLayout.tsx
import { EmailImg } from "@react-email/img"; // plasmic-import: k0LYSWegDX/codeComponent
62

The import statement should look like this now

import EmailImg from "@react-email/img";

How do I force plasmic to re generate this file?

63

I just deleted the file and ran plasmic-watch but it didn’t help

64

do I need to recreate plasmic.json or something?

65

oh! this is a code component, and you changed its isDefaultExport?

66

yes

67

you’ll need to load the plasmic project with the updated host page with the new registration, which is how plasmic learns about the new code component metadata. Then when you do plasmic sync again, it will use the new metadata

68

OK that seemed to work

69

@chungwu One more weird issue…

When I do npm run build i get an error in this plasmic-generated file

./components/OsitoEmailButton.tsx:40:11
Type error: Type '{ dashboardUrl?: string; buttonText?: string; className?: string; }' is not assignable to type '"Unexpected extraneous props"'.

Here’s the plasmic-generated file in question (minus the comments)

import * as React from "react";
import {
  PlasmicOsitoEmailButton,
  DefaultOsitoEmailButtonProps
} from "./plasmic/osito/PlasmicOsitoEmailButton";

export interface OsitoEmailButtonProps extends DefaultOsitoEmailButtonProps {}

function OsitoEmailButton(props: OsitoEmailButtonProps) {
  return <PlasmicOsitoEmailButton {...props} />;
}
70

VSCode also flags the same error when I open that file, fwiw

71

Any ideas?

72

hmm what do you see as the definition for DefaultOsitoEmailButtonProps?

73 
// app/components/plasmic/osito/PlasmicOsitoEmailButton.tsx

export interface DefaultOsitoEmailButtonProps {
  dashboardUrl?: string;
  buttonText?: string;
  className?: string;
}
74

hmm looks right to me… could you put it up on github?

75

sure, it’s here:
https://github.com/ositoai/osito/tree/OSI-379/app
Branch OSI-379

76

any chance there’s something weird in the way OsitoEmailButton is constructed within Plasmic Studio?

image.png
image.png3148×2112 324 KB

77

@chungwu any ideas?

78

yes

79

it’s because the underlying EmailButton component doesn’t take in a className prop

80

huh